Skip to content

mysql lexer, enable lower case letters in variables#1197

Merged
teverett merged 1 commit intoantlr:masterfrom
Biron-BI:mysql_setVarLowerCase
Aug 2, 2018
Merged

mysql lexer, enable lower case letters in variables#1197
teverett merged 1 commit intoantlr:masterfrom
Biron-BI:mysql_setVarLowerCase

Conversation

@PHaroZ
Copy link
Copy Markdown
Contributor

@PHaroZ PHaroZ commented Aug 2, 2018

Hi,

According to https://dev.mysql.com/doc/refman/5.7/en/user-variables.html
variable names could contains lower case letters, yet the lexer does not permit that (only A-Z0-9._$).

Here a small pull request to fix that.

@teverett
Copy link
Copy Markdown
Member

teverett commented Aug 2, 2018

@PHaroZ thanks

@teverett teverett merged commit cdd2a8a into antlr:master Aug 2, 2018
@PHaroZ PHaroZ deleted the mysql_setVarLowerCase branch August 3, 2018 08:58
@KvanTTT
Copy link
Copy Markdown
Member

KvanTTT commented Aug 3, 2018

Why did you merge this request? mysql lexer uses CaseChangingCharStream, so there is no need to use lower-case chars.

Please let me merge *sql grammar pull requests (at least MySQL, T-SQL, PL/SQL).

@KvanTTT KvanTTT mentioned this pull request Aug 3, 2018
Merged
@KvanTTT KvanTTT added invalid mysql-PositiveTechnologies MySql grammar by Positive Technologies issues labels Aug 3, 2018
@PHaroZ
Copy link
Copy Markdown
Contributor Author

PHaroZ commented Aug 3, 2018

Hi,

After other issues about case sensitivity (with sql keyword like SELECT) and some hours spend for searching about that, I find the CaseChangingCharStream doc. I've also read the whole discussion at antlr/antlr4#2046 .
I'm ok with the solution but I think it would be nice if these informations were in the mysql/README.md : this would avoid to people like me to lose some time and, first of all, this would prevent to antlr's maintenairs to merge PR that are not required.

Anyway, thanks for your job.

@KvanTTT
Copy link
Copy Markdown
Member

KvanTTT commented Aug 3, 2018

Ok, you can do it if you want. Also, it makes sense to add such info to the wiki.

@PHaroZ PHaroZ mentioned this pull request Aug 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

invalid mysql-PositiveTechnologies MySql grammar by Positive Technologies issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PHaroZ @teverett @KvanTTT